Issue number: #3358

Summary

Adds addFilter method that was previously missing so static type checkers are happy.

NOTE: By default, Logger proxies any missing public method or attribute to its private logger (_logger) to avoid any runtime issues, so this wasn't an issue at runtime.

Changes

Please provide a summary of what's being changed

• Add addFilter public method
• Add removeFilter public method

Unrelated changes

• Add logging._ExcInfoType in exception() method as per Static typing: Logger.exception() exc_info type does not match Python's built-in one #3356

User experience

Please share what the user experience looks like before and after this change

Experience in adding a filter like it was before but without any mypy errors

import logging
from aws_lambda_powertools.logging import Logger
import secrets

logger = Logger()


class ApiKeyFilter(logging.Filter):
    def filter(self, record):
        if getattr(record, "api_key", None):
            record.api_key = "REDACTED"

        return True


logger.addFilter(ApiKeyFilter())

logger.info("Blah", api_key=secrets.token_urlsafe())

JSON output

{
    "level": "INFO",
    "location": "<module>:18",
    "message": "Blah",
    "timestamp": "2023-11-21 09:59:48,477+0100",
    "service": "service_undefined",
    "api_key": "REDACTED"
}

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.